Skip to content

test: add network collections, struct and class tests MTT-936#1000

Merged
mattwalsh-unity merged 3 commits intodevelopfrom
feature/automate_netvar_testing
Aug 4, 2021
Merged

test: add network collections, struct and class tests MTT-936#1000
mattwalsh-unity merged 3 commits intodevelopfrom
feature/automate_netvar_testing

Conversation

@mattwalsh-unity
Copy link
Copy Markdown
Contributor

No description provided.

@mattwalsh-unity mattwalsh-unity marked this pull request as draft July 30, 2021 03:58
@mattwalsh-unity mattwalsh-unity force-pushed the feature/automate_netvar_testing branch from 04ee3ad to 630c0cf Compare July 31, 2021 00:21
@mattwalsh-unity mattwalsh-unity force-pushed the feature/automate_netvar_testing branch 3 times, most recently from f12bf50 to 79fff4d Compare August 4, 2021 02:58
@mattwalsh-unity
Copy link
Copy Markdown
Contributor Author

@zain-mecklai hey I did a bunch with MultiInstanceHelper here including adding a new helper method and wanted to get your thoughts

@mattwalsh-unity mattwalsh-unity changed the title Feature/automate netvar testing test: add network collections, struct and class tests MTT-936 Aug 4, 2021
@zain-mecklai
Copy link
Copy Markdown
Contributor

@zain-mecklai hey I did a bunch with MultiInstanceHelper here including adding a new helper method and wanted to get your thoughts

@mattwalsh-unity As I read through this it is clear to me that I don't understand enough to be able to provide any kind of useful feedback. I'll continue to work on developing my knowledge and understanding and then will be in a better position to provide feedback.

@mattwalsh-unity mattwalsh-unity marked this pull request as ready for review August 4, 2021 15:10
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwalsh-unity mattwalsh-unity force-pushed the feature/automate_netvar_testing branch from 5ec9b1c to 6620a7c Compare August 4, 2021 19:56
@mattwalsh-unity mattwalsh-unity merged commit 5b9f953 into develop Aug 4, 2021
@mattwalsh-unity mattwalsh-unity deleted the feature/automate_netvar_testing branch August 4, 2021 20:24
SamuelBellomo added a commit that referenced this pull request Aug 11, 2021
…nsform

* develop: (32 commits)
  refactor: calling networkShow(NetworkObject) code in networkshow(List<NetworkObject>) (#1028)
  feat: snapshot. MTT-685 MTT-822 (#1021)
  test: adding a multi-instance test checking NetworkShow and NetworkHide on lists of objects (#1036)
  fix: corrected NetworkVariable WriteField/WriteDelta/ReadField/ReadDelta dropping the last byte if unaligned. (#1008)
  chore: run standards check over solution files (#1027)
  chore: replace MLAPI with Netcode in Markdown files (#1025)
  fix!: added plainly-callable Add() method to NetworkSet [MTT-1005] (#1022)
  fix: fixing incorrect merge done as part of commit 85842ee (#1023)
  chore: cleanup/upgrade serialized scenes (#1020)
  chore: replace MLAPI with Netcode in C# source files (#1019)
  test: add network collections, struct and class tests MTT-936 (#1000)
  test: add buildtests to test build pipeline on target platforms (#1018)
  chore: rename MLAPI types to Netcode (#1017)
  chore!: rename asmdefs, change top-level namespaces (#1015)
  Replacing community NetworkManagerHUD with a simpler implementation (#993)
  test: network prefab pools and INetworkPrefabInstanceHandler (#1004)
  fix: do not expose Runtime internals to TestProject.ManualTests asmdef (#1014)
  refactor: snapshot. merge preparation. Removing old acks, removing unused varia… (#1013)
  chore!: per-asmdef namespaces instead of per-folder (#1009)
  feat: snapshot. ground work, preparing depedencies. No impact on code behaviour (#1012)
  ...

# Conflicts:
#	com.unity.multiplayer.mlapi/Prototyping/NetworkTransform.cs
#	com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants