Skip to content

test: add network collections, struct and class tests MTT-936 #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwalsh-unity merged 3 commits into from
Aug 4, 2021
Merged

test: add network collections, struct and class tests MTT-936 #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5773078
test: add network collections, struct and class tests
mattwalsh-unity Aug 4, 2021
6620a7c
comments, message improved
mattwalsh-unity Aug 4, 2021
5c23184
bad merge
mattwalsh-unity Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions com.unity.multiplayer.mlapi/Runtime/Serialization/NetworkWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,7 @@ public void WriteObjectPacked(object value)
return;
}


throw new ArgumentException($"{nameof(NetworkWriter)} cannot write type {value.GetType()}");
throw new ArgumentException($"{nameof(NetworkWriter)} cannot write type {value.GetType().Name} - it does not implement {nameof(INetworkSerializable)}");
}

/// <summary>
Expand Down
23 changes: 23 additions & 0 deletions com.unity.multiplayer.mlapi/Tests/Runtime/MultiInstanceHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,29 @@ public static IEnumerator GetNetworkObjectByRepresentation(Func<NetworkObject, b
}
}

/// <summary>
/// Runs some code, then verifies the condition (combines 'Run' and 'WaitForCondition')
/// </summary>
/// <param name="workload">Action / code to run</param>
/// <param name="predicate">The predicate to wait for</param>
/// <param name="maxFrames">The max frames to wait for</param>
public static IEnumerator RunAndWaitForCondition(Action workload, Func<bool> predicate, int maxFrames = 64)
{
var waitResult = new CoroutineResultWrapper<bool>();
workload();

yield return Run(WaitForCondition(
predicate,
waitResult,
maxFrames: maxFrames));

if (!waitResult.Result)
{
throw new Exception();
}
}


/// <summary>
/// Waits for a predicate condition to be met
/// </summary>
Expand Down
Loading