test: adding a multi-instance test checking NetworkShow and NetworkHide on lists of objects#1036
Merged
jeffreyrainy merged 2 commits intodevelopfrom Aug 10, 2021
Merged
Conversation
…de on lists of objects
jeffreyrainy
requested review from
0xFA11,
NoelStephensUnity and
SamuelBellomo
0xFA11
reviewed
Aug 10, 2021
Comment on lines
+8
to
+16
| public class NetworkShowHideTest : NetworkBehaviour | ||
| { | ||
|
|
||
| } | ||
|
|
||
| public class ShowHideObject : NetworkBehaviour | ||
| { | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
move these inside the namespace too below?
Contributor
There was a problem hiding this comment.
(and using Unity.Netcode; above would be unnecessary)
0xFA11
reviewed
Aug 10, 2021
com.unity.multiplayer.mlapi/Tests/Runtime/NetworkShowHideTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
approved these changes
Aug 10, 2021
Contributor
0xFA11
left a comment
0xFA11
left a comment
There was a problem hiding this comment.
some nits but looks good to me, thank you! 🚀
SamuelBellomo
added a commit
that referenced
this pull request
Aug 11, 2021
…nsform * develop: (32 commits) refactor: calling networkShow(NetworkObject) code in networkshow(List<NetworkObject>) (#1028) feat: snapshot. MTT-685 MTT-822 (#1021) test: adding a multi-instance test checking NetworkShow and NetworkHide on lists of objects (#1036) fix: corrected NetworkVariable WriteField/WriteDelta/ReadField/ReadDelta dropping the last byte if unaligned. (#1008) chore: run standards check over solution files (#1027) chore: replace MLAPI with Netcode in Markdown files (#1025) fix!: added plainly-callable Add() method to NetworkSet [MTT-1005] (#1022) fix: fixing incorrect merge done as part of commit 85842ee (#1023) chore: cleanup/upgrade serialized scenes (#1020) chore: replace MLAPI with Netcode in C# source files (#1019) test: add network collections, struct and class tests MTT-936 (#1000) test: add buildtests to test build pipeline on target platforms (#1018) chore: rename MLAPI types to Netcode (#1017) chore!: rename asmdefs, change top-level namespaces (#1015) Replacing community NetworkManagerHUD with a simpler implementation (#993) test: network prefab pools and INetworkPrefabInstanceHandler (#1004) fix: do not expose Runtime internals to TestProject.ManualTests asmdef (#1014) refactor: snapshot. merge preparation. Removing old acks, removing unused varia… (#1013) chore!: per-asmdef namespaces instead of per-folder (#1009) feat: snapshot. ground work, preparing depedencies. No impact on code behaviour (#1012) ... # Conflicts: # com.unity.multiplayer.mlapi/Prototyping/NetworkTransform.cs # com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MFatihMAR this test is meant to catch the error you pointed out in this other PR :-)