fix: 2+ inheritance from network behaviour causes compilation exception (#1078)#1079
Merged
becksebenius-unity merged 3 commits intodevelopfrom Aug 23, 2021
Conversation
0xFA11
reviewed
Aug 23, 2021
com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs
Outdated
Show resolved
Hide resolved
0xFA11
suggested changes
Aug 23, 2021
Contributor
0xFA11
left a comment
0xFA11
left a comment
There was a problem hiding this comment.
a minor change is needed and we're good to go here :)
…LPP.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
becksebenius-unity
deleted the
fix/1078-deep-inheritance-causing-compilation-exception
branch
0xFA11
referenced
this pull request
Aug 23, 2021
* feat: expose the name of the network behaviour without runtime alloc * Added test to verify that the name is exposed correctly * removed unnecessary using * code review feedback * fixed bad comment
SamuelBellomo
added a commit
that referenced
this pull request
Aug 26, 2021
…hub.com:Unity-Technologies/com.unity.multiplayer.mlapi into sam/feature/interpolation-for-network-transform * 'sam/feature/interpolation-for-network-transform' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: test: NetworkTransformStateTests no longer uses ReplNetworkState (#1084) fix: networkmanager prefab validation and no scene management manual test (#1073) feat: snapshot. MTT-1088 Snapshot acknowledgment gaps (#1083) feat: Add a test to validate registration of metric types (#1072) chore!: Remove unsupported UNET Relay behavior (MTT-1000) (#1081) fix: 2+ inheritance from network behaviour causes compilation exception (#1078) (#1079) test: add networkscenemanager additive scene loading tests (#1076)
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…on (Unity-Technologies#1078) (Unity-Technologies#1079) * fix: 2+ inheritance from network behaviour causes compilation exception (Unity-Technologies#1078) * Update com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com> * updated comment based on feedback Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the original implementation assumed that a network behaviour's immediate ancestor was NetworkBehaviour. depending on ILPP processing order, a derived class may fail to compile because it cannot find the base class method that is used as a template for the override.
github issue: #1078