test: add networkscenemanager additive scene loading tests#1076
Merged
NoelStephensUnity merged 3 commits intodevelopfrom Aug 23, 2021
Merged
test: add networkscenemanager additive scene loading tests#1076NoelStephensUnity merged 3 commits intodevelopfrom
NoelStephensUnity merged 3 commits intodevelopfrom
Conversation
0xFA11
requested review from
LukeStampfli,
NoelStephensUnity and
mattwalsh-unity
0xFA11
commented
Aug 23, 2021
Comment on lines
+99
to
+100
| // TODO: Remove `m_IsRunningUnitTest` entirely after we switch to multi-process testing | ||
| // In MultiInstance tests, we cannot allow clients to load additional scenes as they're sharing the same scene space / Unity instance. |
Contributor
Author
There was a problem hiding this comment.
in the previous PR #1030, @andrews-unity and @LukeStampfli approved this PR and I also do approve this PR too.
please feel free to approve your own PR @NoelStephensUnity and merge it in :)
Adding check for unit testing at the end of OnClientUnloadScene to determine if we need to just passthrough to the callback (for multiInstance unit testing only) Fixing minor issue with NetworkObject not being around after unloading a scene for NetworkPrefabPool.
NoelStephensUnity
approved these changes
Aug 23, 2021
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
After the last minor adjustments, this PR is good to go.
SamuelBellomo
added a commit
that referenced
this pull request
Aug 26, 2021
…hub.com:Unity-Technologies/com.unity.multiplayer.mlapi into sam/feature/interpolation-for-network-transform * 'sam/feature/interpolation-for-network-transform' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: test: NetworkTransformStateTests no longer uses ReplNetworkState (#1084) fix: networkmanager prefab validation and no scene management manual test (#1073) feat: snapshot. MTT-1088 Snapshot acknowledgment gaps (#1083) feat: Add a test to validate registration of metric types (#1072) chore!: Remove unsupported UNET Relay behavior (MTT-1000) (#1081) fix: 2+ inheritance from network behaviour causes compilation exception (#1078) (#1079) test: add networkscenemanager additive scene loading tests (#1076)
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…hnologies#1076) * redo Unity-Technologies#1030 * comment a todo for `m_IsRunningUnitTest` * test project Adding check for unit testing at the end of OnClientUnloadScene to determine if we need to just passthrough to the callback (for multiInstance unit testing only) Fixing minor issue with NetworkObject not being around after unloading a scene for NetworkPrefabPool. Co-authored-by: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I managed to break PR #1030 — so, I'm fixing and putting this up for review again :)
It's owned by @NoelStephensUnity (sorry!)
This includes the unit testing for additive scene loading using multi-instances.
It includes a minor adjustment to NetworkSceneManager to handle unit testing with multi-instances.
This removes the legacy Runtime NetworkSceneManagerTest and migrates the check for assert when EnableSceneManagement is set to false into the new NetworkSceneManagerTests.
Current Tests: