Skip to content

Update dependency python to 3.14 #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency python to 3.14 #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-rtc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
id: setup-python
with:
python-version: "3.11"
python-version: "3.14"

- name: Build wheels
run: pipx run --python '${{ steps.setup-python.outputs.python-path }}' cibuildwheel==3.3.1 --output-dir dist
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Python 3.9
uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2
with:
python-version: 3.9
python-version: 3.14
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Hardcoded python3.9 path not updated after Python version bump to 3.14

The Python version was changed from 3.9 to 3.14 on line 23, but the Download ffi step on line 38 still uses a hardcoded path .venv/lib/python3.9/site-packages/.... With Python 3.14, the venv's site-packages directory will be .venv/lib/python3.14/site-packages/..., so the FFI binary will be written to a non-existent (or wrong) directory. The subsequent mypy type-checking step will then fail because it won't find the required FFI resources.

Prompt for agents 
The python-version on line 23 was changed from 3.9 to 3.14, but the Download ffi step on line 38 still references a hardcoded path .venv/lib/python3.9/site-packages/livekit/rtc/resources. This path needs to match the Python version. Either update the hardcoded path to python3.14, or better yet, compute the path dynamically using something like: uv run python -c "import sysconfig; print(sysconfig.get_paths()['purelib'])" to get the correct site-packages path regardless of Python version. The affected file is .github/workflows/check-types.yml, specifically line 38.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


- name: Install uv
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: "3.10"
python-version: "3.14"

- name: Install dependencies
run: pip install click packaging
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
id: setup-python
with:
python-version: "3.11"
python-version: "3.14"

- name: Build wheels
run: pipx run --python '${{ steps.setup-python.outputs.python-path }}' cibuildwheel==3.3.1 --output-dir dist
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ruff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # v4
with:
python-version: "3.9"
python-version: "3.14"

- name: Install uv
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5
Expand Down
Loading