Open
Conversation
Generated by renovateBot
| uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2 | ||
| with: | ||
| python-version: 3.9 | ||
| python-version: 3.14 |
Contributor
There was a problem hiding this comment.
🔴 Hardcoded python3.9 path not updated after Python version bump to 3.14
The Python version was changed from 3.9 to 3.14 on line 23, but the Download ffi step on line 38 still uses a hardcoded path .venv/lib/python3.9/site-packages/.... With Python 3.14, the venv's site-packages directory will be .venv/lib/python3.14/site-packages/..., so the FFI binary will be written to a non-existent (or wrong) directory. The subsequent mypy type-checking step will then fail because it won't find the required FFI resources.
Prompt for agents
The python-version on line 23 was changed from 3.9 to 3.14, but the Download ffi step on line 38 still references a hardcoded path .venv/lib/python3.9/site-packages/livekit/rtc/resources. This path needs to match the Python version. Either update the hardcoded path to python3.14, or better yet, compute the path dynamically using something like: uv run python -c "import sysconfig; print(sysconfig.get_paths()['purelib'])" to get the correct site-packages path regardless of Python version. The affected file is .github/workflows/check-types.yml, specifically line 38.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.9→3.143.14.43.11→3.143.14.43.10→3.143.14.4Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
actions/python-versions (python)
v3.14.3: 3.14.3Compare Source
Python 3.14.3
v3.14.2: 3.14.2Compare Source
Python 3.14.2
v3.14.1: 3.14.1Compare Source
Python 3.14.1
v3.14.0: 3.14.0Compare Source
Python 3.14.0
v3.13.13: 3.13.13Compare Source
Python 3.13.13
v3.13.12: 3.13.12Compare Source
Python 3.13.12
v3.13.11: 3.13.11Compare Source
Python 3.13.11
v3.13.10: 3.13.10Compare Source
Python 3.13.10
v3.13.9: 3.13.9Compare Source
Python 3.13.9
v3.13.8: 3.13.8Compare Source
Python 3.13.8
v3.13.7: 3.13.7Compare Source
Python 3.13.7
v3.13.6: 3.13.6Compare Source
Python 3.13.6
v3.13.5: 3.13.5Compare Source
Python 3.13.5
v3.13.4: 3.13.4Compare Source
Python 3.13.4
v3.13.3: 3.13.3Compare Source
Python 3.13.3
v3.13.2: 3.13.2Compare Source
Python 3.13.2
v3.13.1: 3.13.1Compare Source
Python 3.13.1
v3.13.0: 3.13.0Compare Source
Python 3.13.0
v3.12.13: 3.12.13Compare Source
Python 3.12.13
v3.12.12: 3.12.12Compare Source
Python 3.12.12
v3.12.11: 3.12.11Compare Source
Python 3.12.11
v3.12.10: 3.12.10Compare Source
Python 3.12.10
v3.12.9: 3.12.9Compare Source
Python 3.12.9
v3.12.8: 3.12.8Compare Source
Python 3.12.8
v3.12.7: 3.12.7Compare Source
Python 3.12.7
v3.12.6: 3.12.6Compare Source
Python 3.12.6
v3.12.5: 3.12.5Compare Source
Python 3.12.5
v3.12.4: 3.12.4Compare Source
Python 3.12.4
v3.12.3: 3.12.3Compare Source
Python 3.12.3
v3.12.2: 3.12.2Compare Source
Python 3.12.2
v3.12.1: 3.12.1Compare Source
Python 3.12.1
v3.12.0: 3.12.0Compare Source
Python 3.12.0
v3.11.15: 3.11.15Compare Source
Python 3.11.15
v3.11.14: 3.11.14Compare Source
Python 3.11.14
v3.11.13: 3.11.13Compare Source
Python 3.11.13
v3.11.12: 3.11.12Compare Source
Python 3.11.12
v3.11.11: 3.11.11Compare Source
Python 3.11.11
v3.11.10: 3.11.10Compare Source
Python 3.11.10
v3.11.9: 3.11.9Compare Source
Python 3.11.9
v3.11.8: 3.11.8Compare Source
Python 3.11.8
v3.11.7: 3.11.7Compare Source
Python 3.11.7
v3.11.6: 3.11.6Compare Source
Python 3.11.6
v3.11.5: 3.11.5Compare Source
Python 3.11.5
v3.11.4: 3.11.4Compare Source
Python 3.11.4
v3.11.3: 3.11.3Compare Source
Python 3.11.3
v3.11.2: 3.11.2Compare Source
Python 3.11.2
v3.11.1: 3.11.1Compare Source
Python 3.11.1
v3.11.0: 3.11.0Compare Source
Python 3.11.0
v3.10.20: 3.10.20Compare Source
Python 3.10.20
v3.10.19: 3.10.19Compare Source
Python 3.10.19
v3.10.18: 3.10.18Compare Source
Python 3.10.18
v3.10.17: 3.10.17Compare Source
Python 3.10.17
v3.10.16: 3.10.16Compare Source
Python 3.10.16
v3.10.15: 3.10.15Compare Source
Python 3.10.15
v3.10.14: 3.10.14Compare Source
Python 3.10.14
v3.10.13: 3.10.13Compare Source
Python 3.10.13
v3.10.12: 3.10.12Compare Source
Python 3.10.12
v3.10.11: 3.10.11Compare Source
Python 3.10.11
v3.10.10: 3.10.10Compare Source
Python 3.10.10
v3.10.9: 3.10.9Compare Source
Python 3.10.9
v3.10.8: 3.10.8Compare Source
Python 3.10.8
v3.10.7: 3.10.7Compare Source
Python 3.10.7
v3.10.6: 3.10.6Compare Source
Python 3.10.6
v3.10.5: 3.10.5Compare Source
Python 3.10.5
v3.10.4: 3.10.4Compare Source
Python 3.10.4
v3.10.3: 3.10.3Compare Source
Python 3.10.3
v3.10.2: 3.10.2Compare Source
Python 3.10.2
v3.10.1: 3.10.1Compare Source
Python 3.10.1
v3.10.0: 3.10.0Compare Source
Python 3.10.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.