Skip to content

fix: Empty prefab removal on init #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlao merged 1 commit into from
Jun 28, 2021
Merged

fix: Empty prefab removal on init #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,9 +496,10 @@ private void Initialize(bool server)
}

// Clear out anything that is invalid or not used (for invalid entries we already logged warnings to the user earlier)
foreach (var networkPrefabIndexToRemove in removeEmptyPrefabs)
// Iterate backwards so indices don't shift as we remove
for (int i = removeEmptyPrefabs.Count-1; i >= 0; i--)
{
NetworkConfig.NetworkPrefabs.RemoveAt(networkPrefabIndexToRemove);
NetworkConfig.NetworkPrefabs.RemoveAt(removeEmptyPrefabs[i]);
}
removeEmptyPrefabs.Clear();

Expand Down