Skip to content

fix: Increase timeout for UTP adapter tests #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-lemay-unity merged 3 commits into from
Sep 17, 2021
Merged

fix: Increase timeout for UTP adapter tests #1199

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53917ed
Increase timeout for UTP adapter tests
simon-lemay-unity Sep 17, 2021
4b2359c
fix: Increase timeout for UTP adapter tests
simon-lemay-unity Sep 17, 2021
80dc47d
Merge branch 'fix/utp-adapter-test-timeouts' of github.com:Unity-Tech…
simon-lemay-unity Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions com.unity.netcode.adapter.utp/Tests/Runtime/Helpers/RuntimeTestsHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ namespace Unity.Netcode.UTP.RuntimeTests
{
public static class RuntimeTestsHelpers
{
// 50ms should be plenty enough for any network interaction to occur (even roundtrips).
#if UNITY_STANDALONE_OSX || UNITY_EDITOR_OSX || UNITY_ANDROID
public const float MaxNetworkEventWaitTime = 0.35f;
#else
public const float MaxNetworkEventWaitTime = 0.15f;
#endif
// Half a second might seem like a very long time to wait for a network event, but in CI
// many of the machines are underpowered (e.g. old Android devices or Macs) and there are
// sometimes lag spikes that cause can cause delays upwards of 300ms.
public const float MaxNetworkEventWaitTime = 0.5f;

// Wait for an event to appear in the given event list (must be the very next event).
public static IEnumerator WaitForNetworkEvent(NetworkEvent type, List<TransportEvent> events)
Expand Down