fix: Increase timeout for UTP adapter tests#1199
Merged
simon-lemay-unity merged 3 commits intodevelopfrom Sep 17, 2021
Merged
Conversation
Was 150ms or 350ms depending on the platform. Now bumped to 500ms for all platforms since there were occurences of tests timing out in CI.
andrews-unity
approved these changes
Sep 17, 2021
Was 150ms or 350ms depending on the platform. Now bumped to 500ms for all platforms since there were occurences of tests timing out in CI.
…nologies/com.unity.netcode.gameobjects into fix/utp-adapter-test-timeouts
SamuelBellomo
added a commit
that referenced
this pull request
Sep 17, 2021
* develop: feat: INetworkMessage (#1187) fix: Increase timeout for UTP adapter tests (#1199) docs: Update repo and both package readme files (#1180) chore: updating UTP package to pull in DTLS fixes (#1197) fix: network time arguments (#1194) feat: network physics (#1175) # Conflicts: # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs # com.unity.netcode.gameobjects/Components/NetworkTransform.cs # testproject/Assets/Prefabs/PlayerCube.prefab
SamuelBellomo
added a commit
that referenced
this pull request
Sep 17, 2021
…transform-teleport * sam/feature/client-network-transform: adding proper delta sending feat: INetworkMessage (#1187) fix: Increase timeout for UTP adapter tests (#1199) docs: Update repo and both package readme files (#1180) chore: updating UTP package to pull in DTLS fixes (#1197) fix: network time arguments (#1194) feat: network physics (#1175) # Conflicts: # testproject/Assets/Scenes/ZooSam.unity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears there can be important lag spikes in CI which can cause UTP adapter tests to fail sporadically. To avoid creating noise when merging unrelated changes, increase the maximum time we wait for network events in the adapter tests. If failures are still observed, we'll raise it again.
Eventually we'll implement a better way to handle these timeouts while also being able to identify performance regressions.