test: base changes to PR-1114#1165
Merged
NoelStephensUnity merged 14 commits intodevelopfrom Sep 14, 2021
Merged
Conversation
Contributor
|
These changes look fine to me. I have to admit I don't understand the implications of everything going on here so I can't provide a more detailed review. |
zain-mecklai
approved these changes
Sep 14, 2021
Contributor
zain-mecklai
left a comment
zain-mecklai
left a comment
There was a problem hiding this comment.
I tested them out and they appear to have solved all the problems.
0xFA11
reviewed
Sep 14, 2021
Comment on lines
813
to
+815
| } | ||
|
|
||
|
|
||
| #if UNITY_EDITOR || DEVELOPMENT_BUILD | ||
| #if UNITY_INCLUDE_TESTS |
Contributor
There was a problem hiding this comment.
I'm still not sure how this macro works and I wouldn't advise to change it if not necessary.
Member
Author
There was a problem hiding this comment.
This is defined in the com.unity.netcode.runtimetests.asmdef file:
"defineConstraints": [
"UNITY_INCLUDE_TESTS"
],
According to @JesseOlmer it is the preferred define to use for this particular scenario.
0xFA11
reviewed
Sep 14, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs
Show resolved
Hide resolved
0xFA11
reviewed
Sep 14, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs
Outdated
Show resolved
Hide resolved
…processTests.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
SamuelBellomo
added a commit
that referenced
this pull request
Sep 16, 2021
…nsform * develop: feat: NetworkBehaviour.IsSpawned (#1190) feat: added tip to the network manager inspector that directs to install tools (MTT-1211) (#1182) refactor!: remove network dictionary & set, use native container in List, add tests (#1149) fix: Fixed remote disconnects not properly cleaning up (#1184) test: base changes to PR-1114 (#1165) test: verify do not destroy networkobjects on networkmanager shutdown (#1183) chore: removal of EnableNetworkVariable in NetworkConfig. It's always True now (#1179) fix: Fix DontDestroyWithOwner not returning ownership (#1181) test: Giving Android some more room as the connection tests are timing sensitive (#1178) fix: unitytransport connectionmode buttons (#1176) test: added min frames to multi-instance helper (#1170) chore: Add mobile tests to nightly trigger (#1161) feat: snapshot spawn pre-requisite (#1166) feat: Unity Transport + Relay (#887) feat: client scene synchronization mode (#1171) # Conflicts: # testproject/Assets/Scenes/SampleScene.unity
SamuelBellomo
added a commit
that referenced
this pull request
Sep 16, 2021
…am/feature/client-network-transform * sam/feature/interpolation-for-network-transform: (22 commits) fixing line issue more formatting fixing formatting issue removing not submitted LiteNetLib from ZooSam feat: Fast buffer reader and fast buffer writer (#1082) restricting public api bumping exec order feat: NetworkBehaviour.IsSpawned (#1190) feat: added tip to the network manager inspector that directs to install tools (MTT-1211) (#1182) refactor!: remove network dictionary & set, use native container in List, add tests (#1149) fix: Fixed remote disconnects not properly cleaning up (#1184) test: base changes to PR-1114 (#1165) test: verify do not destroy networkobjects on networkmanager shutdown (#1183) chore: removal of EnableNetworkVariable in NetworkConfig. It's always True now (#1179) fix: Fix DontDestroyWithOwner not returning ownership (#1181) test: Giving Android some more room as the connection tests are timing sensitive (#1178) fix: unitytransport connectionmode buttons (#1176) test: added min frames to multi-instance helper (#1170) chore: Add mobile tests to nightly trigger (#1161) feat: snapshot spawn pre-requisite (#1166) ... # Conflicts: # com.unity.netcode.gameobjects/Components/NetworkTransform.cs # testproject/Assets/Scenes/SampleScene.unity
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
* Refactor The base requirements to build and run multiprocess stuff. * style removing LF * fix Adding back the multiprocess ignore capabilities with the ability to easily override this ignore for continued development work. * fix including the IgnorMultiprocessTests test check for the NetworkVariablePerformanceTests * style fixing white space formatting issue due to indentation. * Update testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com> * fix spelling of IgnoreMultiprocessTests Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base requirements to build and run multiprocess tests with a minor adjustment to the KillProcesses method.
This PR disables the Multiprocess tests by default, but they can be enabled while continuing development by including the following command line argument:
-bypassIgnoreUTR