Skip to content

Philippe/ubuntu2404 fix#372

Merged
zollqir merged 19 commits intomainfrom
philippe/ubuntu2404-fix
Jul 16, 2024
Merged

Philippe/ubuntu2404 fix#372
zollqir merged 19 commits intomainfrom
philippe/ubuntu2404-fix

Conversation

@philippedistributive
Copy link
Copy Markdown
Collaborator

@philippedistributive philippedistributive commented Jul 9, 2024

Fix setup issues on ubuntu 24.04 and add that target to CI

closes #356

@philippedistributive
Copy link
Copy Markdown
Collaborator Author

philippedistributive commented Jul 11, 2024

CodeQL failure can be ignored

Xmader
Xmader reviewed Jul 11, 2024
View reviewed changes
Comment thread .github/workflows/test-and-publish.yaml Outdated
Xmader
Xmader reviewed Jul 11, 2024
View reviewed changes
Comment thread .github/workflows/test-and-publish.yaml
@philippedistributive
Copy link
Copy Markdown
Collaborator Author

philippedistributive commented Jul 12, 2024

Tom Tang 3:15 PM
@philippe Laporte
Liang was saying in the issue he failed on Source Distribution (pip installing from a .tar.gz sdist file containing only the source code like https://nightly.pythonmonkey.io/pythonmonkey/pythonmonkey-0.6.1.dev220+80e90a4.tar.gz than a Python wheel .whl file containing the built binary)
Your changes to setup.sh don't even run when the current CI installs pythonmonkey for testing, from a .whl file.
Instead of simply adding the Ubuntu 24.04 runners to the CI, what you should test in this PR is to try in Ubuntu 24.04 to install from the sdist file, built by the sdist CI.

@zollqir zollqir force-pushed the philippe/ubuntu2404-fix branch from fca6a45 to daeb266 Compare July 16, 2024 14:10
zollqir
zollqir requested changes Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zollqir zollqir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small changes required

Comment thread .github/workflows/test-and-publish.yaml
Comment thread .github/workflows/test-and-publish.yaml Outdated
Comment thread .github/workflows/test-and-publish.yaml Outdated
Comment thread .github/workflows/test-and-publish.yaml Outdated
Comment thread .github/workflows/test-and-publish.yaml Outdated
Comment thread .github/workflows/test-and-publish.yaml
philippedistributive and others added 5 commits July 16, 2024 11:31
@philippedistributive @zollqir
Update .github/workflows/test-and-publish.yaml
310ccf1 
Co-authored-by: Caleb Aikens <caleb@distributive.network>
@philippedistributive @zollqir
Update .github/workflows/test-and-publish.yaml
f854430 
Co-authored-by: Caleb Aikens <caleb@distributive.network>
@philippedistributive @zollqir
Update .github/workflows/test-and-publish.yaml
1d776f6 
Co-authored-by: Caleb Aikens <caleb@distributive.network>
@philippedistributive @zollqir
Update .github/workflows/test-and-publish.yaml
b319ae6 
Co-authored-by: Caleb Aikens <caleb@distributive.network>
@philippedistributive
fixup
4ef34d2
zollqir
zollqir previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zollqir zollqir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when CI is green

zollqir
zollqir approved these changes Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zollqir zollqir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I believe this also closes #373

@zollqir zollqir merged commit e77643f into main Jul 16, 2024
@zollqir zollqir deleted the philippe/ubuntu2404-fix branch July 16, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xmader Xmader Xmader left review comments

@zollqir zollqir zollqir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

python3-distutils is not a thing on Ubuntu 24.04 LTS

3 participants

@philippedistributive @Xmader @zollqir