Can't install pythonmonkey in docker

[oaguirre-vb]

Issue type

Build/Install

How did you install PythonMonkey?

Installed from pip

OS platform and distribution

Docker - Linux Ubuntu 22.04

Python version (python --version)

Python 3.10

PythonMonkey version (pip show pythonmonkey)

No response

Bug Description

When I try use pip install pythonmonkey , I keep getting an error concerning git/hooks/precommit

And I try to clone the repo and run ./setup.sh it halts at Installing Poetry and I eventually have to kill the process.

Standalone code to reproduce the issue

No response

Relevant log output or backtrace

Building wheel for pythonmonkey (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for pythonmonkey (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [31 lines of output]
      ln: failed to create symbolic link '.git/hooks/pre-commit': No such file or directory
      Traceback (most recent call last):
        File "/tmp/pip-install-c1evfcjb/pythonmonkey_acb4d454b9204488b9c90dab0b5bf611/build.py", line 81, in <module>       
          build()
        File "/tmp/pip-install-c1evfcjb/pythonmonkey_acb4d454b9204488b9c90dab0b5bf611/build.py", line 74, in build
          ensure_spidermonkey()
        File "/tmp/pip-install-c1evfcjb/pythonmonkey_acb4d454b9204488b9c90dab0b5bf611/build.py", line 41, in ensure_spidermonkey
          execute("bash ./setup.sh", cwd=TOP_DIR)
        File "/tmp/pip-install-c1evfcjb/pythonmonkey_acb4d454b9204488b9c90dab0b5bf611/build.py", line 31, in execute        
          raise subprocess.CalledProcessError(return_code, cmd)
      subprocess.CalledProcessError: Command 'bash ./setup.sh' returned non-zero exit status 1.
      Traceback (most recent call last):
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
          main()
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 261, in build_wheel        
          return _build_backend().build_wheel(wheel_directory, config_settings,
        File "/tmp/pip-build-env-szdkvi5b/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/api.py", line 58, in build_wheel
          return WheelBuilder.make_in(
        File "/tmp/pip-build-env-szdkvi5b/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/builders/wheel.py", line 88, in make_in
          wb.build(target_dir=directory)
        File "/tmp/pip-build-env-szdkvi5b/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/builders/wheel.py", line 123, in build
          self._build(zip_file)
        File "/tmp/pip-build-env-szdkvi5b/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/builders/wheel.py", line 172, in _build
          self._run_build_script(self._package.build_script)
        File "/tmp/pip-build-env-szdkvi5b/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/builders/wheel.py", line 262, in _run_build_script
          subprocess.check_call([self.executable.as_posix(), build_script])
        File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
          raise CalledProcessError(retcode, cmd)
      subprocess.CalledProcessError: Command '['/usr/bin/python3', 'build.py']' returned non-zero exit status 1.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pythonmonkey
Failed to build pythonmonkey
ERROR: Could not build wheels for pythonmonkey, which is required to install pyproject.toml-based projects

Additional info if applicable

No response

What branch of PythonMonkey were you developing on? (If applicable)

No response

[philippedistributive]

@caleb-distributive This is quite possibly a regression caused by recent build system changes

[Xmader]

d4c9223 added the git commit hooks.

[zollqir]

This will be fixed in the release today

[taivokasper]

@caleb-distributive I think it is still broken

Test with this Dockerfile:

FROM node:20.15.1-slim

RUN apt-get update -y \
    && apt-get install -y python3-pip python3-dev python3-venv

ENV VIRTUAL_ENV=/opt/venv
RUN python3 -m venv $VIRTUAL_ENV
ENV PATH="$VIRTUAL_ENV/bin:$PATH"

RUN pip install --upgrade pip

RUN pip install --extra-index-url https://nightly.pythonmonkey.io/ --pre pythonmonkey

build command: docker build -f Dockerfile -t pythonmonkey:test .

Error:

53.86       Rust is installed now. Great!
53.86
53.86       To get started you may need to restart your current shell.
53.86       This would reload your PATH environment variable to include
53.86       Cargo's bin directory ($HOME/.cargo/bin).
53.86
53.86       To configure your current shell, you need to source
53.86       the corresponding env file under $HOME/.cargo.
53.86
53.86       This is usually done by running one of the following (note the leading DOT):
53.86       . "$HOME/.cargo/env"            # For sh/bash/zsh/ash/dash/pdksh
53.86       source "$HOME/.cargo/env.fish"  # For fish
53.86       ./setup.sh: line 37: cargo: command not found
53.86       Traceback (most recent call last):
53.86         File "/tmp/pip-install-kcmgztbj/pythonmonkey_d33c5d07339e429b829557e6f0e54316/build.py", line 77, in <module>
53.86           build()
53.86         File "/tmp/pip-install-kcmgztbj/pythonmonkey_d33c5d07339e429b829557e6f0e54316/build.py", line 70, in build
53.86           ensure_spidermonkey()
53.86         File "/tmp/pip-install-kcmgztbj/pythonmonkey_d33c5d07339e429b829557e6f0e54316/build.py", line 44, in ensure_spidermonkey
53.86           execute("bash ./setup.sh", cwd=TOP_DIR)
53.86         File "/tmp/pip-install-kcmgztbj/pythonmonkey_d33c5d07339e429b829557e6f0e54316/build.py", line 34, in execute
53.86           raise subprocess.CalledProcessError(return_code, cmd)
53.86       subprocess.CalledProcessError: Command 'bash ./setup.sh' returned non-zero exit status 127.
53.86       Traceback (most recent call last):
53.86         File "/opt/venv/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
53.86           main()
53.86         File "/opt/venv/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
53.86           json_out['return_val'] = hook(**hook_input['kwargs'])
53.86                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
53.86         File "/opt/venv/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 251, in build_wheel
53.86           return _build_backend().build_wheel(wheel_directory, config_settings,
53.86                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
53.86         File "/tmp/pip-build-env-_r4u5wuy/overlay/lib/python3.11/site-packages/poetry/core/masonry/api.py", line 58, in build_wheel
53.86           return WheelBuilder.make_in(
53.86                  ^^^^^^^^^^^^^^^^^^^^^
53.86         File "/tmp/pip-build-env-_r4u5wuy/overlay/lib/python3.11/site-packages/poetry/core/masonry/builders/wheel.py", line 88, in make_in
53.86           wb.build(target_dir=directory)
53.86         File "/tmp/pip-build-env-_r4u5wuy/overlay/lib/python3.11/site-packages/poetry/core/masonry/builders/wheel.py", line 123, in build
53.86           self._build(zip_file)
53.86         File "/tmp/pip-build-env-_r4u5wuy/overlay/lib/python3.11/site-packages/poetry/core/masonry/builders/wheel.py", line 172, in _build
53.86           self._run_build_script(self._package.build_script)
53.86         File "/tmp/pip-build-env-_r4u5wuy/overlay/lib/python3.11/site-packages/poetry/core/masonry/builders/wheel.py", line 262, in _run_build_script
53.86           subprocess.check_call([self.executable.as_posix(), build_script])
53.86         File "/usr/lib/python3.11/subprocess.py", line 413, in check_call
53.86           raise CalledProcessError(retcode, cmd)
53.86       subprocess.CalledProcessError: Command '['/opt/venv/bin/python3', 'build.py']' returned non-zero exit status 1.
53.86       [end of output]

[zollqir]

This looks to be a different issue than the git hooks one, we're not configuring the current shell to include cargo (. $HOME/.cargo/env) before using it. I'll make a quick patch for this.