Skip to content

Comments

increase initial command timeout to 30s from 5s (slow WSL start)#2853

Merged
sawka merged 1 commit intomainfrom
sawka/wsl-timeouts
Feb 10, 2026
Merged

increase initial command timeout to 30s from 5s (slow WSL start)#2853
sawka merged 1 commit intomainfrom
sawka/wsl-timeouts

Conversation

@sawka
Copy link
Member

@sawka sawka commented Feb 10, 2026

No description provided.

@sawka sawka merged commit 8abe3f0 into main Feb 10, 2026
1 of 2 checks passed
@sawka sawka deleted the sawka/wsl-timeouts branch February 10, 2026 23:33
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The StartConnServer function in pkg/wslconn/wslconn.go has its connection timeout duration increased. Specifically, the timeout for reading the version line from the connection controller's output is changed from 5 seconds to 30 seconds. This modification affects the error path timing when the version line is not received within the specified duration. No other logic or functionality is altered by this change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawka/wsl-timeouts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

stevenwang288 pushed a commit to stevenwang288/waveterm that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant