Merged
Conversation
✅ Deploy Preview for tsky ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Coverage Report for ./packages/client/
File CoverageNo changed files found. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will suspend auto lexicon updates by GitHub Actions. A better way would be adopting atcute's latest lexicons.
I don't have enough time working on tsky/nimbus these days (sorry 🙏🏻) and I've been updating only lexicons, but if I understand correctly,
@atcute/blueskyand other packages now export types for the latest lexicons (ref. https://npmx.dev/package/@atcute/bluesky) since its marjor update around Spring 2025 and we could use them instead of repeating its maintainance and generation.Our lexicon generator is based on a very old internal generator of atcute and it requires a deep understanding of atproto lexicons to maintain. While we should switch to the atcute lexicons, the migration involves major changes. This branch (https://github.com/tsky-dev/tsky/tree/shuuji3/chore/migrate-atcute-lexicon-packages) was my previous attempt to replace
@tsky/lexiconwith atcute lexicon but it has not been fully tested and gone stale now 🥲FYI: @patak-dev