Python 3 support (closes #34)#36
Merged
techtonik merged 1 commit intotechtonik:masterfrom Feb 12, 2016
yan12125:py3
Merged
Conversation
Contributor
Author
|
Great! All tests passed https://travis-ci.org/techtonik/python-patch/builds/103869201. |
Owner
|
Wow. Thanks. It is a pity that we text file need to be treated as binary. I need some time to think about that, but on the first glimpse it looks like there is no other choice. |
Owner
|
Thanks. I merged it, because it works. =) Better do post-review. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I start this work from scratch. None of previous patches are used.