Closed
Conversation
El script está diseñado para ser usado ya sea como un hook de pre-commit, o (principalmente) dentro de una nuevo paso del GitHub action que revisa PRs, de tal modo que se añada y actualice automáticamente un comentario en el PR indicando si todas las entradas del archivo siendo traducido han sido completadas o no. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
rtobar
force-pushed
the
test-pr-comments
branch
4 times, most recently
from
a1362cf to
c73e835
Compare
|
Entries missing translation, details follow:
|
1 similar comment
|
Entries missing translation, details follow:
|
rtobar
force-pushed
the
test-pr-comments
branch
from
c73e835 to
a680490
Compare
|
Entries missing translation, details follow:
|
2 similar comments
|
Entries missing translation, details follow:
|
|
Entries missing translation, details follow:
|
|
Entries missing translation, details follow:
|
rtobar
force-pushed
the
test-pr-comments
branch
from
d9b144c to
dd24edf
Compare
|
All entries translated, horray! 🎉 |
rtobar
force-pushed
the
test-pr-comments
branch
from
bf19c5e to
3f0bf4c
Compare
rtobar
force-pushed
the
test-pr-comments
branch
from
3f0bf4c to
c98249f
Compare
rtobar
added a commit
to python/python-docs-es
that referenced
this pull request
Nov 6, 2023
Este PR agrega una nueva acción que agrega un comentario a los PRs que editan archivos .po indicando qué entradas aún no tienen una traducción. Un ejemplo de esto funcionando se puede ver en rtobar#3. Hay varios comentarios automáticos porque use ese PR para debuguear el proceso, pero la idea es que finalmente haya un solo comentario que se va actualizando (como se puede ver en el último comentario, que está editado). Otro ejemplo se puede ver en rtobar#5, donde el PR viene desde un fork en vez de venir desde el mismo repositorio. Otra opción habría sido agregar un check a CI que falle si faltan entradas, pero en 3.11 ya tuvimos el caso en que *tuvimos* que dejar entradas fuzzy a propósito. --------- Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.