Rename remove() to delete() for consistency with PSR-16#30
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Jun 8, 2018
Merged
Rename remove() to delete() for consistency with PSR-16#30WyriHaximus merged 1 commit intoreactphp:masterfrom
WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
jsor
reviewed
Jun 8, 2018
Member
Author
|
@jsor Good catch, updated! |
jsor
approved these changes
Jun 8, 2018
Member
Author
|
Rebased on master to resolve merge conflict now that #29 is in |
WyriHaximus
approved these changes
Jun 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR renames the existing
remove()method todelete()for consistency with PSR-6 and PSR-16. It also adds some documentation to be in line with #16 and #29, but the behavior is otherwise left unchanged.Empirical evidence suggests that this method is rarely used and this release includes a number of BC breaks that aim at making this interface act more like a standard PSR-16 cache, so I figured it makes sense to rename this as part of this release.