Fix Unicode character error building Japanese PDF documents#145
Fix Unicode character error building Japanese PDF documents#145atsuoishimoto wants to merge 0 commit intopython:mainfrom
Conversation
| @@ -226,9 +226,11 @@ class Language: | |||
| ) | |||
|
|
|||
| PLATEX_DEFAULT = ( | |||
There was a problem hiding this comment.
| PLATEX_DEFAULT = ( | |
| LUALATEX_DEFAULT = ( |
Should the variable name be updated too?
build_docs.py
Outdated
| Language("id", "id", "Indonesian", False, XELATEX_DEFAULT), | ||
| Language("it", "it", "Italian", False, XELATEX_DEFAULT), | ||
| Language("ja", "ja", "Japanese", True, PLATEX_DEFAULT, html_only=True), # See https://github.com/python/python-docs-ja/issues/35 | ||
| Language("ja", "ja", "Japanese", True, PLATEX_DEFAULT, html_only=True), |
There was a problem hiding this comment.
| Language("ja", "ja", "Japanese", True, PLATEX_DEFAULT, html_only=True), | |
| Language("ja", "ja", "Japanese", True, LUALATEX_DEFAULT, html_only=True), |
Also later in the file there's a piece of code that prints the platex version, that should be updated to print the lualatex version instead if platex is no longer used anywhere.
|
If I undertand correctly this PR is stuck with the newlines in the preamble? |
|
As a「 « "temporary" » 」fix, would running: help? It could be easily added to docsbuild script inside an |
e096f71 to
3a75c4d
Compare
|
Sorry, I had to start over with a new branch. Please take a look at #149. |
With this change, the pdf is fine. But unfortunately, the HTML document will be messed up. I gave up to support U+FFFD with luatex(for now). Please refer #149. |
Fix Unicode character error building Japanese PDF documents.
See python/python-docs-ja#31, python/python-docs-ja#35