Skip to content

Solved issue #522#623

Closed
aliya-rahmani wants to merge 7 commits intopython:masterfrom
aliya-rahmani:master
Closed

Solved issue #522#623
aliya-rahmani wants to merge 7 commits intopython:masterfrom
aliya-rahmani:master

Conversation

@aliya-rahmani
Copy link
Copy Markdown
Contributor

Simplified language in translation page

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@aliya-rahmani

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Copy Markdown
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aliya-rahmani. Thanks for the documentation change. Please submit the CLA if you haven't already done so. It will automatically update to signed status a day or two after it is submitted.

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
aliya-rahmani and others added 2 commits October 20, 2020 09:09
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@aliya-rahmani
Copy link
Copy Markdown
Contributor Author

@willingc I've done the recommended changes and signed CLA as well.

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Oct 20, 2020

Looks like the 2 commits from #628 have been accidentally included here.

Please could you undo those two from here?

@aliya-rahmani
Copy link
Copy Markdown
Contributor Author

@hugovk I've undone the changes and now the pull request is having 7 commits.

@willingc
Copy link
Copy Markdown
Collaborator

Hi @aliya-rahmani, I've merged in your PR #630 and left you a link to a section of the devguide. Would you be able to update this PR to only contain those that relate to documenting.rst?

Remember, for the future, when creating a new change it's important to develop on a new branch instead of master. This will minimize merge conflicts and extraneous files in your new branch when you open a PR. 👍

@willingc willingc added the needs: PR update An update or rebase to an existing PR is needed. label Oct 21, 2020
@aliya-rahmani
Copy link
Copy Markdown
Contributor Author

aliya-rahmani commented Oct 25, 2020

Hi @willingc, thank's a lot for the guidelines, I'm a beginner so just having some issues with understanding things. I've made a new PR #638 for the issue, plz have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: PR update An update or rebase to an existing PR is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants