bpo-33772: Fix couple of dead code paths#7418
Merged
Conversation
methane
approved these changes
Jun 6, 2018
methane
reviewed
Jun 6, 2018
Member
methane
left a comment
There was a problem hiding this comment.
In ast.c and compile.c, break before next case seems worth.
It notes that "this case clause doesn't fallthrough".
Others seems good to me.
Author
|
In ast.c and compile.c they always return before the |
Member
I know. But the case clause is not so simple. It takes several seconds to read code for knowing it. |
Author
|
I hope I m not asking too much :-) but any opinion on this older PR ? |
Contributor
|
Closing and re-opening to retrigger CI checks. |
Contributor
|
@dcarlier-afilias, thank you for the pull request and, @methane, thank you for the code review and approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33772