gh-149021: Fix AIX build by dropping -e from SHELL in Makefile#149022
Closed
pratyush618 wants to merge 1 commit intopython:mainfrom
Closed
gh-149021: Fix AIX build by dropping -e from SHELL in Makefile#149022pratyush618 wants to merge 1 commit intopython:mainfrom
-e from SHELL in Makefile#149022pratyush618 wants to merge 1 commit intopython:mainfrom
Conversation
Member
For those reasons, I'm closing the PR until we have a cleaner fix that doesn't mess with the entire build system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On AIX,
make(1)treats the value ofSHELLas a literal executablepath rather than a command line. Since gh-100220 the top-level Makefile
sets
SHELL = /bin/sh -eto make complex recipes fail-fast under GNUmake, but AIX then tries to
execve("/bin/sh -e", ...)and the buildaborts immediately:
POSIX requires
maketo invoke the shell with-eby default; GNUmake does the same once a
.POSIX:special target is declared (it sets.SHELLFLAGS = -ec). This PR:.POSIX:as the first non-comment line inMakefile.pre.in;SHELL = /bin/shso the value is a valid path on AIX;make sharedinstalldoes not return failure if install commands fail #100220 on both POSIX andGNU make.
Verified locally with GNU Make 4.3 that a multi-command recipe
(
echo a; false; echo b) aborts afterfalsewith.POSIX:set,matching the prior
SHELL = /bin/sh -ebehavior.SHELLinMakefilefor AIX builds? #149021