gh-148817: Fold long lists/sets of constant elements into constant tuples/frozensets#149016
Open
Eclips4 wants to merge 2 commits intopython:mainfrom
Open
gh-148817: Fold long lists/sets of constant elements into constant tuples/frozensets#149016Eclips4 wants to merge 2 commits intopython:mainfrom
Eclips4 wants to merge 2 commits intopython:mainfrom
Conversation
Eclips4
requested review from
AA-Turner,
ezio-melotti,
hugovk,
iritkatriel,
markshannon and
webknjaz
as code owners
Contributor
|
thanks for the PR @Eclips4 ! |
iritkatriel
reviewed
Apr 27, 2026
| LIST_APPEND 1 | ||
| CALL_INTRINSIC_1 INTRINSIC_LIST_TO_TUPLE | ||
| LIST_APPEND/SET_ADD 1 | ||
| [CALL_INTRINSIC_1 INTRINSIC_LIST_TO_TUPLE] <-- when intrinsic_at_i is true |
Member
There was a problem hiding this comment.
Can intrinsic_at_i be renamed to something clearer? Maybe just expected_append?
|
|
||
| if (expect_append) { | ||
| if (opcode != LIST_APPEND || oparg != 1) { | ||
| if (opcode != append_op || oparg != 1) { |
Member
There was a problem hiding this comment.
Why did this need to change?
| if (oparg == INTRINSIC_LIST_TO_TUPLE) { | ||
| if (nextop == GET_ITER) { | ||
| RETURN_IF_ERROR(fold_constant_intrinsic_list_to_tuple(bb, i, consts, const_cache, consts_index)); | ||
| /* If folding didn't apply, the list-to-tuple conversion |
Member
There was a problem hiding this comment.
Is this related to the current PR? It seems like a separate optimisation.
Also, why is the to-tuple redundant only when the folding did not apply? If it's folded it's already a tuple, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in/not inandforloops #148817