gh-126835: Fix _PY_IS_SMALL_INT() macro#146631
Merged
vstinner merged 1 commit intopython:mainfrom Mar 30, 2026
Merged
Conversation
skirpichev
approved these changes
Mar 30, 2026
skirpichev
reviewed
Mar 30, 2026
| #define medium_value(x) ((stwodigits)_PyLong_CompactValue(x)) | ||
|
|
||
| #define IS_SMALL_INT(ival) (-_PY_NSMALLNEGINTS <= (ival) && (ival) < _PY_NSMALLPOSINTS) | ||
| #define IS_SMALL_INT(ival) _PY_IS_SMALL_INT(ival) |
Member
Author
There was a problem hiding this comment.
Well, IS_SMALL_INT() is shorter and is used in multiple functions. IMO IS_SMALL_INT() is more readable than _PY_IS_SMALL_INT(), and it avoids changing the code.
| return -1; | ||
| } | ||
| if (!overflow && _PY_IS_SMALL_INT(val)) { | ||
| if (!overflow && _PY_IS_SMALL_INT(val) && 0 <= val && val <= 255) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!overflow && _PY_IS_SMALL_INT(val) && 0 <= val && val <= 255) { | |
| if (!overflow && _PY_IS_SMALL_INT(val) && 0 <= val && val < 256) { |
Member
Author
There was a problem hiding this comment.
Well, that's the same, and I prefer <= 255 :-)
maurycy
added a commit
to maurycy/cpython
that referenced
this pull request
Mar 30, 2026
…ktor * upstream/main: (119 commits) pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845) pythongh-146558: JIT optimize dict access for objects with known hash (python#146559) pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570) pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631) pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593) pythongh-138122: Add differential flame graph (python#145785) pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417) pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628) pythongh-138850: Add --disable-epoll to configure (pythonGH-145768) pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624) pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597) pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557) pythongh-146579: _zstd: Fix decompression options dict error message (python#146577) pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085) pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573) pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569) pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472) pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580) pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004) pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.