GH-145247: Use _PyTuple_FromPair[Steal] in Objects#145884
Open
sergey-miryanov wants to merge 5 commits intopython:mainfrom
Open
GH-145247: Use _PyTuple_FromPair[Steal] in Objects#145884sergey-miryanov wants to merge 5 commits intopython:mainfrom
sergey-miryanov wants to merge 5 commits intopython:mainfrom
Conversation
sergey-miryanov
requested review from
JelleZijlstra,
markshannon and
methane
as code owners
methane
reviewed
Mar 23, 2026
Objects/stringlib/unicode_format.h
Outdated
| result = _PyTuple_FromPairSteal(is_attr_obj, obj); | ||
| return result; | ||
|
|
||
| done: |
Objects/stringlib/unicode_format.h
Outdated
| result = _PyTuple_FromPairSteal(first_obj, (PyObject *)it); | ||
| return result; | ||
|
|
||
| done: |
methane
reviewed
Mar 23, 2026
| to_delete = PyObject_RichCompareBool(val1, val2, Py_EQ); | ||
| Py_DECREF(val1); | ||
| if (to_delete < 0) { | ||
| goto error; |
Member
There was a problem hiding this comment.
Is this safe? If goto error happens, won't it decref twice?
Contributor
Author
There was a problem hiding this comment.
You are right, it is not safe. I don't understand why I did this (blame on me).
methane
reviewed
Mar 23, 2026
Objects/listobject.c
Outdated
| @@ -1439,7 +1439,7 @@ list_extend_dictitems(PyListObject *self, PyDictObject *dict) | |||
| Py_ssize_t i = 0; | |||
| PyObject *key_value[2]; | |||
sergey-miryanov
commented
Mar 23, 2026
Contributor
Author
sergey-miryanov
left a comment
sergey-miryanov
left a comment
There was a problem hiding this comment.
Address review
Objects/stringlib/unicode_format.h
Outdated
| result = _PyTuple_FromPairSteal(is_attr_obj, obj); | ||
| return result; | ||
|
|
||
| done: |
Objects/stringlib/unicode_format.h
Outdated
| result = _PyTuple_FromPairSteal(first_obj, (PyObject *)it); | ||
| return result; | ||
|
|
||
| done: |
Objects/listobject.c
Outdated
| @@ -1439,7 +1439,7 @@ list_extend_dictitems(PyListObject *self, PyDictObject *dict) | |||
| Py_ssize_t i = 0; | |||
| PyObject *key_value[2]; | |||
…ey-miryanov/cpython into feat/145247-pytuple-from-pair-use-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a second PR for usage of _PyTuple_FromPair[Steal] in the codebase.
PyTuple_FromPair#145247