gh-145230: Update lockbench.py and benchmark_locks API#145271
Closed
gourijain029-del wants to merge 1 commit intopython:mainfrom
Closed
gh-145230: Update lockbench.py and benchmark_locks API#145271gourijain029-del wants to merge 1 commit intopython:mainfrom
gourijain029-del wants to merge 1 commit intopython:mainfrom
Conversation
- Remove PyThread_type_lock benchmark as it now uses PyMutex.\n- Add --work-outside to adjust work outside critical sections.\n- Add --num-locks to support benchmarking multiple independent locks.\n- Make number of threads configurable.\n- Add --total-iters for fixed iteration benchmarks.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
|
Thank you, but I already have a PR that makes the changes I described. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Updates
lockbench.py
and the internal
benchmark_locks
API to support more realistic PyMutex benchmarking.
Key Changes:
New Metrics: Added --work-outside, --num-locks, and --total-iters to simulate varying contention levels and measure fairness.
Redundancy: Removed PyThread_type_lock benchmarking as it now uses PyMutex.
CLI: Switched to argparse and made the number of threads configurable.
Efficiency: Added cache-line padding to mutex states in C to prevent false sharing during multi-lock tests.