GH-65961: Stop setting __cached__ on modules#142165
Merged
brettcannon merged 4 commits intopython:mainfrom Dec 11, 2025
Merged
Conversation
brettcannon
requested review from
AA-Turner,
FFY00,
ambv,
ericsnowcurrently,
lysnikolaou,
ncoghlan,
pablogsal,
warsaw and
willingc
as code owners
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 12, 2025
DimitriPapadopoulos
left a comment
DimitriPapadopoulos
left a comment
There was a problem hiding this comment.
@brettcannon This change puts the __cached__ deprecation notices under the __file__ attribute. I find this confusing::
| instead of :attr:`!module.__path__`. | ||
|
|
||
| .. attribute:: module.__file__ | ||
| .. attribute:: module.__cached__ |
There was a problem hiding this comment.
I can understand why module.__cached__ is removed here, but __cached__ remains implicitly referred to in ensuing deprecation notices.
| :attr:`module.__spec__.cached <importlib.machinery.ModuleSpec.cached>` | ||
| instead of :attr:`!module.__cached__`. | ||
|
|
||
| .. deprecated-removed:: 3.13 3.15 |
There was a problem hiding this comment.
Perhaps reintroduce attribute module.__cached__ here, or move the __cached__ deprecation notices elsewhere, not under module.__file__.
Member
Author
That's a syntax mistake in the docs. Can you please open an issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--142165.org.readthedocs.build/