GH-130415: Use boolean guards to narrow types to values in the JIT#130659
Merged
brandtbucher merged 13 commits intopython:mainfrom Mar 2, 2025
Merged
GH-130415: Use boolean guards to narrow types to values in the JIT#130659brandtbucher merged 13 commits intopython:mainfrom
brandtbucher merged 13 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a symbolic "truth" type to the JIT optimizer, allowing tests like
if not x: ...to narrow the value ofxbased on its type. Currently, it's only implemented for booleans, but I'm working with a few people to open PRs to narrowintandstrvalues as well.(The diff looks much worse than it is, since this requires adding
ctxparameters to a couple of helper functions that are used everywhere. The "real" changes inoptimizer_bytecodes.care limited to_GUARD_IS_FALSE_POP,_GUARD_IS_NONE_POP,_GUARD_IS_TRUE_POP,_TO_BOOL,_TO_BOOL_BOOL, and_UNARY_NOT.