Added support for the onRelayouting event.#201
Merged
dmt0 merged 1 commit intoplotly:masterfrom Sep 14, 2020
Merged
Conversation
Contributor
|
Thanks @lauri-codes for your contibution! This event wasn't only missing here, but also from our documentation (plotly/graphing-library-docs#94). All that's left here is to update the readme (there's a list of events there) and this PR is good to go! |
Contributor
|
Readme update done in #202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
onRelayoutingevent was missing.Adding it seemed almost too easy... Just with these two lines I was able to get it working on my application. Can you maybe check that this is correct? Especially my assumption about needing to add the event name in the
updateEventsarray.I did not see any event-specific tests in the regression tests files so I didn't add any.