[Bug] Component generation needs double quote extract_path#3621
Open
antonymilne wants to merge 2 commits intoplotly:devfrom
Open
[Bug] Component generation needs double quote extract_path#3621antonymilne wants to merge 2 commits intoplotly:devfrom
extract_path#3621antonymilne wants to merge 2 commits intoplotly:devfrom
Conversation
Contributor
|
But now it fails on windows, it seems like the extract path is collated with the previous argument: Maybe we could not use the shlex.split and pass the command argument like |
Replace shlex.split with direct list arguments and remove shell=True to avoid quoting issues on Windows.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when the path to
extract-meta.jscontains a space, thenodecommand run during component generation crashes with an error like this:Note the path should be "Application Support/..." but it got cut off. Now with the quote marks it should all work nicely 🎉