Skip to content

test: improve test-cluster-net-send.js#9570

Closed
akito0107 wants to merge 1 commit intonodejs:masterfrom
akito0107:improve-test-cluster-net-send
Closed

test: improve test-cluster-net-send.js#9570
akito0107 wants to merge 1 commit intonodejs:masterfrom
akito0107:improve-test-cluster-net-send

Conversation

@akito0107
Copy link
Copy Markdown
Contributor

@akito0107 akito0107 commented Nov 12, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, cluster

Description of change

This commit improves test-cluster-net-send as below;

  • use port 0 instead of common.PORT
  • use common.mustCall
  • use assert.strictEqual instead of assert.equal
  • change var to const or let (if possible)
  • change function to arrow function

This is a part of Code And Learn at NodeFest 2016 Challenge
nodejs/code-and-learn#58

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem. net Issues and PRs related to the net subsystem. stalled Issues and PRs that are stalled. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants