test: clean tls-connect-given-socket#8616
Closed
thomasvanlankveld wants to merge 4 commits intonodejs:masterfrom
thomasvanlankveld:clean-test-tls-connect-given-socket
Closed
test: clean tls-connect-given-socket#8616thomasvanlankveld wants to merge 4 commits intonodejs:masterfrom thomasvanlankveld:clean-test-tls-connect-given-socket
thomasvanlankveld wants to merge 4 commits intonodejs:masterfrom
thomasvanlankveld:clean-test-tls-connect-given-socket
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesDescription of change
Changed vars to consts and lets, assert.equals to assert.strictEquals and added
common.mustCall around a connect callback