util: add hex colors support in styleText#61556
util: add hex colors support in styleText#61556araujogui wants to merge 9 commits intonodejs:mainfrom
styleText#61556Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61556 +/- ##
=======================================
Coverage 89.71% 89.71%
=======================================
Files 676 676
Lines 206751 206817 +66
Branches 39645 39665 +20
=======================================
+ Hits 185482 185556 +74
+ Misses 13403 13390 -13
- Partials 7866 7871 +5
🚀 New features to boost your workflow:
|
ljharb
left a comment
There was a problem hiding this comment.
Please add test cases for invalid values.
e4dff45 to
012abfa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
8eb2649 to
e90ab1c
Compare
RafaelGSS
left a comment
There was a problem hiding this comment.
Since we don't have a green CI yet, would you mind including hex to styleText benchmarks? We are working to improve that, and it would be interesting to see if this decreases performance.
9a04738 to
543d851
Compare
|
@araujogui everything passed and I'm happy merging this, but there's one final conflict. Apologies, I was sick these days and wasn't able to circle back here! |
543d851 to
98f7371
Compare
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
98f7371 to
f943683
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@aduh95 any idea? It's so weird the tests are failing this much, that's lots of flakiness. And it is always node-test-commit-windows-fanned that fails. More specifically |
Fixes #61543