Skip to content

src: migrate String::Value to String::ValueView#55458

Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom
avivkeller:v8-string--value-deprecate
Oct 29, 2024
Merged

src: migrate String::Value to String::ValueView#55458
nodejs-github-bot merged 5 commits intonodejs:mainfrom
avivkeller:v8-string--value-deprecate

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Oct 19, 2024

Fixes #54417
Ref: #55452

v8::String::Value is deprecated, so this PR replaces it with v8::String::ValueView

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@vmoroz vmoroz vmoroz approved these changes

@anonrig anonrig anonrig approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v8::String::Value is deprecated

8 participants

@avivkeller @nodejs-github-bot @aduh95 @targos @jasnell @addaleax @vmoroz @anonrig