Skip to content

test_runner: run before hook immediately if test started#52003

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
MoLow:test-runner-run-before-immidiatly
Mar 9, 2024
Merged

test_runner: run before hook immediately if test started#52003
nodejs-github-bot merged 2 commits intonodejs:mainfrom
MoLow:test-runner-run-before-immidiatly

Conversation

@MoLow
Copy link
Copy Markdown
Member

@MoLow MoLow commented Mar 7, 2024

Fixes #51371

instead of the previous fix not running hooks when no tests,
this makes sure before and after hooks run regardless of the existence of subtests

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_runner: after() hook is called for no subtests

6 participants