crypto: use openssl's own memory BIOs in crypto_context.cc#47160
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 18, 2023
GauriSpears:main
Merged
crypto: use openssl's own memory BIOs in crypto_context.cc#47160nodejs-github-bot merged 1 commit intonodejs:mainfrom GauriSpears:main
nodejs-github-bot merged 1 commit intonodejs:mainfrom
GauriSpears:main
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeBIO's memory buffer structure does not support BIO_C_FILE_SEEK and B IO_C_FILE_TELL. This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys. So I switched to OpenSSL's own protected memory bu ffers.
Fixes: #47008