Skip to content

url: preserve null char in WHATWG URL errors#42263

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Trott:url-null
Mar 11, 2022
Merged

url: preserve null char in WHATWG URL errors#42263
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Trott:url-null

Conversation

@Trott
Copy link
Copy Markdown
Member

@Trott Trott commented Mar 9, 2022

A null character in the middle of an invalid URL was resulting in an
error message that truncated the input string. This preserves the entire
input string in the error message.

Refs: #39592

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants