Skip to content

tls: Use SHA1 for sessionIdContext in FIPS mode#3755

Closed
stefanmb wants to merge 1 commit intonodejs:masterfrom
stefanmb:fips-cs4-tls-wrap
Closed

tls: Use SHA1 for sessionIdContext in FIPS mode#3755
stefanmb wants to merge 1 commit intonodejs:masterfrom
stefanmb:fips-cs4-tls-wrap

Conversation

@stefanmb
Copy link
Contributor

By default, a call to tls.createServer() without a sessionIdContext will use a “MD5 hash value generated from command-line” as per documentation.

In FIPS mode MD5 is not allowed, however createServer is often called without specifying an explicit sessionIdContext. A significant number of test cases and applications break. The simple solution is to to use an allowed hash function. I have chosen SHA1 and truncated the output to 128 bits (which is the hardcoded length required by OpenSSL’s SSL_MAX_SID_CTX_LENGTH).

Note that I have opted to maintain the use of MD5 in non-FIPS mode, and updated the documentation accordingly.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants