Skip to content

http: add complete property#28628

Closed
ronag wants to merge 2 commits intonodejs:masterfrom
nxtedition:feat-http-complete
Closed

http: add complete property#28628
ronag wants to merge 2 commits intonodejs:masterfrom
nxtedition:feat-http-complete

Conversation

@ronag
Copy link
Copy Markdown
Member

@ronag ronag commented Jul 10, 2019

This is a suggestion to add a complete property to http request and response to indicate that no further work can/should be performed on the instance.

I believe this is a better alternative to the current finished property which I believe is currently incorrectly used in a lot of scenarios.

Depends on #28621 and #28627 which should probably first be merged.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jul 10, 2019
@ronag ronag changed the title Feat http complete http: add complete property Jul 10, 2019
@mscdex
Copy link
Copy Markdown
Contributor

mscdex commented Jul 10, 2019

Missing documentation?

@ronag
Copy link
Copy Markdown
Member Author

ronag commented Jul 10, 2019

@mscdex I'd like to ask for some feedback on whether this is a valid suggestion before I spend time on docs and tests.

@BridgeAR
Copy link
Copy Markdown
Member

@nodejs/http PTAL

@ronag
Copy link
Copy Markdown
Member Author

ronag commented Jul 13, 2019

@benjamingr since you approved the closed PR do you think this PR is something worth spending further work on?

@benjamingr
Copy link
Copy Markdown
Member

I am really not sure but I am game going on a zoom or chat to understand all the changes you want to make to HTTP at once so I can understand the motivation and make a better decision.

@ronag
Copy link
Copy Markdown
Member Author

ronag commented Jul 13, 2019

@benjamingr sounds good to me, how do we go about setting that up?

@benjamingr
Copy link
Copy Markdown
Member

Ping relevant parties and maybe someone from the TSC with access to the zoom? Maybe Matteo (though he probably won't have time in the coming week - probably later)

@ronag ronag mentioned this pull request Aug 5, 2019
4 tasks
@ronag
Copy link
Copy Markdown
Member Author

ronag commented Aug 5, 2019

replaced by #28968

@ronag ronag closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants