Skip to content

assert: remove unreachable code#27786

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:assertion-error-unreachable
Closed

assert: remove unreachable code#27786
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:assertion-error-unreachable

Conversation

@Trott
Copy link
Copy Markdown
Member

@Trott Trott commented May 20, 2019

In lib/internal/assert/assertion_error.js, line 391 assures that
operator is 'deepEqual' so there is no need to check the value of
operator in a ternary on the next line (line 392). Remove the ternary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants