src: clean up node::Init() wrt embedder scenarios#25370
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: clean up node::Init() wrt embedder scenarios#25370addaleax wants to merge 1 commit intonodejs:masterfrom
node::Init() wrt embedder scenarios#25370addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the STL variant of
node::Init()a bit moresuitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes