Skip to content

benchmark: allow to add lines to scatter plots#22074

Closed
lundibundi wants to merge 2 commits intonodejs:masterfrom
lundibundi:add-lines-scatter
Closed

benchmark: allow to add lines to scatter plots#22074
lundibundi wants to merge 2 commits intonodejs:masterfrom
lundibundi:add-lines-scatter

Conversation

@lundibundi
Copy link
Member

Adds --add-lines option to scatter.R that will add lines between the points of the same category.

It was helpful for me to see a general trend with different options, so I added this.
Also, this is my first time working with R so please be thorough, maybe I've missed something.

Checklist
  • make -j4 test (UNIX) passes
  • documentation is changed or added (I'll change benchmark guide later it this is an acceptable change)
  • commit message follows [commit guidelines]

test-plot
test-plot-lines

/cc @nodejs/benchmarking

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants