Skip to content

vm: add bindings for v8::CompileFunctionInContext#21571

Closed
ryzokuken wants to merge 1 commit intonodejs:masterfrom
ryzokuken:vm-compile-function
Closed

vm: add bindings for v8::CompileFunctionInContext#21571
ryzokuken wants to merge 1 commit intonodejs:masterfrom
ryzokuken:vm-compile-function

Conversation

@ryzokuken
Copy link
Copy Markdown
Contributor

@ryzokuken ryzokuken commented Jun 28, 2018

Adds a method compileFunction to the vm module, which serves as a
binding for v8::CompileFunctionInContext with appropriate args for
specifying the details, and provide params for the wrapper.

Eventually, we would be changing Module._compile to use this internally
over the standard Module.wrap

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
TODO
  • Add documentation
  • Add more test cases? (Please suggest any test cases you have in mind)

/cc @nodejs/vm @nodejs/v8 @hashseed

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. semver-minor PRs that contain new features and should be released in the next minor version. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.