lib, src: use process.config instead of regex#17814
Closed
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-abort-config
Closed
lib, src: use process.config instead of regex#17814maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:jm-abort-config
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-abort-config
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is safer to use a
process.binding('config')defined boolean, than toregex on
process.execArgv. Also, this better falls in line with theconventions of checking flags passed to the executable.
I verified that
test/async-hooks/test-callback-error.jsproperly tests this.First time contributing to the C++ side of Node, please send all the advice 😆
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib, src, async_hooks