Skip to content

build: clean up config_fips.gypi#13837

Closed
danbev wants to merge 2 commits intonodejs:masterfrom
danbev:cleanup-config_fips.gypi
Closed

build: clean up config_fips.gypi#13837
danbev wants to merge 2 commits intonodejs:masterfrom
danbev:cleanup-config_fips.gypi

Conversation

@danbev
Copy link
Copy Markdown
Contributor

@danbev danbev commented Jun 21, 2017

Currently when configuring the project using --openssl-fips a gyp
include file name config_fips.gypi will be created. If the project is
later configured but without the --openssl-fips flag an error will
occur. For example:

  $ ./configure --openssl-fips=bogus
  $ ./configure && make -j8
  ...
  /node/deps/openssl/fips/fipsld:
  line 8: /bin/fipsld: No such file or directory
  Error 127

This commit suggests removing the generate config_fips.gypi when the
--openssl-fips flag is not give on the command line.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. embedding Issues and PRs related to embedding Node.js in another project. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants