Provide def file for windows import lib#17
Merged
legendecas merged 2 commits intonodejs:mainfrom Mar 29, 2023
Merged
Conversation
add .def file gen
Julusian
approved these changes
Mar 22, 2023
Contributor
Author
|
let's merge |
Contributor
Author
legendecas
approved these changes
Mar 28, 2023
NickNaso
reviewed
Mar 29, 2023
Member
NickNaso
left a comment
There was a problem hiding this comment.
Hi @Pospelove,
maybe it could be better to put the definition files in a folder like def and then update the index.js in something like repoterd below:
'use strict'
const path = require('path');
const symbols = require('./symbols')
const include_dir = path.resolve(__dirname, 'include');
const js_native_def = path.resolve(__dirname, 'def','js_native_api.def');
const node_api_def = path.resolve(__dirname, 'def', 'node_api.def');
const def = {
js_native_def,
node_api_def
}
module.exports = {
include_dir,
symbols,
def
}What do you think about?
If you agree with my proposal please update the documentation https://github.com/nodejs/node-api-headers/pulls#api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15
example PR created by updated workflow: Pospelove#2