chore: extract skipTest into its own harness module#56
Merged
legendecas merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
Move skipTest from features.js into a dedicated skip-test.js file, matching the pattern of other harness utilities (assert, must-call, gc). Add a harness test to verify the global exists. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
@bavulapati I'd appreciate a review 👍 |
1 task
legendecas
approved these changes
Apr 27, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's follow a pattern of separating harness utilities into separate files and have a test for each to make it easier for implementors to implement the harness.
Summary
skipTestfromimplementors/node/features.jsinto a dedicatedimplementors/node/skip-test.js, matching the pattern of other harness utilities (assert, must-call, gc, load-addon)--importfor the new module inimplementors/node/tests.tstests/harness/skip-test.jsto verify theskipTestglobal is available as a functionTest plan
skip-test.js🤖 Generated with Claude Code