feat: add spawnTest harness global#54
Open
bavulapati wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
bavulapati
force-pushed
the
feat/spawn-test-global
branch
from
525bba8 to
9adf4db
Compare
bavulapati
force-pushed
the
feat/spawn-test-global
branch
from
9adf4db to
2795471
Compare
bavulapati
added a commit
to bavulapati/node-api-cts
that referenced
this pull request
Apr 17, 2026
Member
|
I don't expect all implementors to have multi-process support where the harness is able to spawn up sub-processes. The emnapi and React Native implementors in particular won't be straight forward, if possible at all. We could add another flag to skip the tests which needs this? 🤔 But that would entail a lower coverage on the implementors which doesn't support this "harness feature", which is not great. There's also the option of potentially refactoring the tests which needs this, into not needing sub-process spawning. Got any other ideas? |
legendecas
reviewed
Apr 27, 2026
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
I think spawn is highly coupled with a specific runtime, like CLI options. Could this be a more generic helper?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be used in test_exception and test_finalizer