add an all plaform supported cleanup solution#780
Open
Vizonex wants to merge 2 commits intonodejs:mainfrom
Open
add an all plaform supported cleanup solution#780Vizonex wants to merge 2 commits intonodejs:mainfrom
Vizonex wants to merge 2 commits intonodejs:mainfrom
Conversation
ShogunPanda
requested changes
Feb 24, 2026
Contributor
ShogunPanda
left a comment
There was a problem hiding this comment.
It looks fine to me.
Just two minor things:
- Can you move it to the scripts folder?
- Can you make sure it's properly formatted according to our linting rules?
Contributor
Author
|
I sure can, give me a couple of minutes. |
Contributor
Author
|
@ShogunPanda About what you told me I am in a bit of confusion as to what folder specifically to move this new
I had it in the |
Contributor
|
@Vizonex My bad. I meant you to create a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been an ongoing issue for users using Windows who try and compile llhttp where the remove command
rmwouldn't work (because it doesn't exist on windows) so I came up a logical solution that tries to fix this and hopefully make it so that other users don't fall under the same boat.fixes #767