Skip to content

add an all plaform supported cleanup solution#780

Open
Vizonex wants to merge 2 commits intonodejs:mainfrom
Vizonex:all-platform-support-rm
Open

add an all plaform supported cleanup solution#780
Vizonex wants to merge 2 commits intonodejs:mainfrom
Vizonex:all-platform-support-rm

Conversation

@Vizonex
Copy link
Contributor

@Vizonex Vizonex commented Nov 6, 2025

There has been an ongoing issue for users using Windows who try and compile llhttp where the remove command rm wouldn't work (because it doesn't exist on windows) so I came up a logical solution that tries to fix this and hopefully make it so that other users don't fall under the same boat.

fixes #767

Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me.
Just two minor things:

  1. Can you move it to the scripts folder?
  2. Can you make sure it's properly formatted according to our linting rules?

@Vizonex
Copy link
Contributor Author

Vizonex commented Feb 24, 2026

I sure can, give me a couple of minutes.

@Vizonex
Copy link
Contributor Author

Vizonex commented Feb 24, 2026

@ShogunPanda About what you told me I am in a bit of confusion as to what folder specifically to move this new clean.ts file.

  1. Can you move it to the scripts folder?

I had it in the bin folder due to believing it was where such scripts were to be stored but would I be moving this new clean.ts script to the src folder or does this request imply I make a new scripts folder for this specific tool?

@Vizonex Vizonex requested a review from ShogunPanda February 24, 2026 18:52
@ShogunPanda
Copy link
Contributor

@Vizonex My bad. I meant you to create a new /scripts folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build parser on windows

2 participants