Bah, I assume this would have been much easier if I'd not mucked up the API.
It's possible we can squash it down into less commits for a backport.
I'd like to see this since it would be useful to have this information in LTS for tooling. It's far less desirable to have to float this patch or patch in _unrefed for APIs that don't have it (e.g. child_process, whereas net and timers have this.)
This will be even more prevalent if/once anything from AsyncWrap gets backported, or even with it's existing API. Specifically, there is no way to tell if a handle will or will not keep the process open without this.
It presents next-to zero risk as far as I can tell. Below is the full commit chain.
cc @thealphanerd
Bah, I assume this would have been much easier if I'd not mucked up the API.
It's possible we can squash it down into less commits for a backport.
I'd like to see this since it would be useful to have this information in LTS for tooling. It's far less desirable to have to float this patch or patch in
_unrefedfor APIs that don't have it (e.g.child_process, whereas net and timers have this.)This will be even more prevalent if/once anything from
AsyncWrapgets backported, or even with it's existing API. Specifically, there is no way to tell if a handle will or will not keep the process open without this.It presents next-to zero risk as far as I can tell. Below is the full commit chain.
cc @thealphanerd